This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
Network diagnostics #1758
Merged
Network diagnostics #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjg
force-pushed
the
network-diagnostics
branch
2 times, most recently
from
832c296
to
cb60d28
Compare
FintanH
force-pushed
the
daemon
branch
2 times, most recently
from
c6dd9d7
to
dc720af
Compare
FintanH
force-pushed
the
daemon
branch
3 times, most recently
from
f0e022e
to
ec4b81a
Compare
FintanH
force-pushed
the
daemon
branch
3 times, most recently
from
19a36f1
to
3d076fb
Compare
alexjg
force-pushed
the
network-diagnostics
branch
from
be1c149
to
4464fdf
Compare
alexjg
force-pushed
the
network-diagnostics
branch
from
cc282fc
to
22f36ef
Compare
alexjg
force-pushed
the
network-diagnostics
branch
4 times, most recently
from
eb30877
to
ad34082
Compare
Signed-off-by: Alex Good <alex@memoryandthought.me>
alexjg
force-pushed
the
network-diagnostics
branch
from
ad34082
to
01213fb
Compare
|
This should be ready to take another look at. The only remaining irritation is that |
|
@brandonhaslegs and I might take a stab at styling this a bit. Should we push to this PR or branch of of this? |
As discussed, we’ll move forward merging this PR and you can create a separate PR to update the styles. |
This was referenced Jun 21, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a network diagnostics screen - accessible via a
<ctrl>-ishortcut - which shows the waiting room state and any events that change the state of the waiting room.